RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap

[Jaikiran Pai]

On Thu, 14 Mar 2024 04:11:14 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8328066?
> 
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue, the failure was observed on linux-86 instance on a GitHub jobs run. 
> 
> The commit in this PR proposes to add relevant `@requires` so that the test is only run on 64 bit VM and expects the `os.maxMemory` to be > 2G.
> 
> The change has been tested on a linux-x86 run in GitHub actions job, plus even on local and CI 64 bit VM environments. No failures have been noticed.

Hello Daniel,



> LGTM.
> 
> I see that some other tests have things like:
> 
> ```
> * @requires vm.bits == "64" & os.maxMemory > 4G
> ```
> 
> Not sure what is the preferred form in such cases: two `@requires` or a single one?

As per jtreg doc, semantically they would be the same:

>
> The @requires tag may be used multiple times in a given test. If it is used more than once, the expressions in the individual instances will be enclosed in parentheses and combined with '&'.

However, your suggestion I think is a good one, since it makes it quicker to notice the requirements instead of having it spread across on multiple lines. I'll update the PR to implement your suggestion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18290#issuecomment-1997267874