RFR: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock [v2]
Viktor Klang
vklang at openjdk.org
Wed May 1 10:58:53 UTC 2024
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
>
> Update src/java.base/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java
>
> Co-authored-by: Pavel Rappo <32523691+pavelrappo at users.noreply.github.com>
src/java.base/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java line 162:
> 160: * }
> 161: * }
> 162: * // Make sure that code that could throw is executed inside the try block
@pavelrappo Or something like:
Suggestion:
* // Potentially throwing code should be placed inside the try block
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18974#discussion_r1586174747
More information about the core-libs-dev
mailing list