RFR: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock [v2]
Viktor Klang
vklang at openjdk.org
Fri May 10 14:42:14 UTC 2024
On Wed, 1 May 2024 10:03:25 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> The grammar rules prefer "that" because it is a restrictive clause, even though "which" might sound better. See for example: https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html
>
>> The grammar rules prefer "that" because it is a restrictive clause, even though "which" might sound better. See for example: https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html
>
> Thanks for that link, Doug.
>
> I understand that two "that"s that are that close to each other might sound a bit weird. (Obviously, I exaggerated the issue in that preceding sentence.) Can we maybe rephrase it then?
>
>
> * // If code could throw, make sure that it is executed inside try block
@pavelrappo Ok to integrate? 🤔
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18974#issuecomment-2104730094
More information about the core-libs-dev
mailing list