RFR: 8305457: Implement java.io.IO
Pavel Rappo
prappo at openjdk.org
Tue May 7 17:01:53 UTC 2024
On Tue, 7 May 2024 01:20:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and three methods to `java.io.Console` for [Implicitly Declared Classes and Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge --squash` of a now obsolete [draft PR].
>>
>> [Implicitly Declared Classes and Instance Main Methods (Third Preview)]: https://bugs.openjdk.org/browse/JDK-8323335
>> [draft PR]: https://github.com/openjdk/jdk/pull/18921
>
> src/java.base/share/classes/java/io/Console.java line 189:
>
>> 187: /**
>> 188: * Writes a prompt as if by calling {@code print}, then reads a single line
>> 189: * of text from this system console.
>
> Nit: I would not add `system` here as `this console` is consistent with other locations.
That is a typo; thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1592805571
More information about the core-libs-dev
mailing list