RFR: 8305457: Implement java.io.IO [v3]
Stuart Marks
smarks at openjdk.org
Tue May 7 21:24:53 UTC 2024
On Tue, 7 May 2024 19:46:18 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and three methods to `java.io.Console` for [Implicitly Declared Classes and Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge --squash` of a now obsolete [draft PR].
>>
>> [Implicitly Declared Classes and Instance Main Methods (Third Preview)]: https://bugs.openjdk.org/browse/JDK-8323335
>> [draft PR]: https://github.com/openjdk/jdk/pull/18921
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>
> Strengthen tests after 8330998
>
> https://github.com/openjdk/jdk/pull/18996 now allows us to test
> Console IO better.
src/java.base/share/classes/java/io/IO.java line 37:
> 35: * is {@code null}; otherwise, the effect is as if a similarly-named method
> 36: * had been called on that console.
> 37: *
Add a note here on encoding (character set), something like
Output from methods in this class uses the character set of the system console as specified by {@link Console#charset}.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593109243
More information about the core-libs-dev
mailing list