RFR: 8305457: Implement java.io.IO [v3]
Pavel Rappo
prappo at openjdk.org
Tue May 7 22:16:52 UTC 2024
On Tue, 7 May 2024 21:19:59 GMT, Stuart Marks <smarks at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Strengthen tests after 8330998
>>
>> https://github.com/openjdk/jdk/pull/18996 now allows us to test
>> Console IO better.
>
> src/java.base/share/classes/java/io/IO.java line 37:
>
>> 35: * is {@code null}; otherwise, the effect is as if a similarly-named method
>> 36: * had been called on that console.
>> 37: *
>
> Add a note here on encoding (character set), something like
>
>
> Output from methods in this class uses the character set of the system console as specified by {@link Console#charset}.
Seems redundant since we express `IO` methods in therms of those of `Console` in the specification, no?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593161920
More information about the core-libs-dev
mailing list