RFR: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook [v9]

Naoto Sato naoto at openjdk.org
Fri May 24 15:38:16 UTC 2024


> Making sure `restoreEcho` correctly reflects the state in the shutdown thread, which differs from the application's thread that issues the `readPassword()` method.

Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
 - Used a dedicate lock for restoreEcho
 - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
 - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
 - copyright year
 - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
 - get/setEcho()
 - Addresses a review comment
 - Replaced another unused exception with _
 - Update src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java
   
   Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
 - ... and 1 more: https://git.openjdk.org/jdk/compare/472fb9f3...69ec27d6

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19184/files
  - new: https://git.openjdk.org/jdk/pull/19184/files/f69f747a..69ec27d6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19184&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19184&range=07-08

  Stats: 14344 lines in 304 files changed: 9600 ins; 3407 del; 1337 mod
  Patch: https://git.openjdk.org/jdk/pull/19184.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19184/head:pull/19184

PR: https://git.openjdk.org/jdk/pull/19184


More information about the core-libs-dev mailing list