RFR: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook [v9]
Stuart Marks
smarks at openjdk.org
Fri May 24 16:16:07 UTC 2024
On Fri, 24 May 2024 15:38:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown thread, which differs from the application's thread that issues the `readPassword()` method.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
> - Used a dedicate lock for restoreEcho
> - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
> - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
> - copyright year
> - Merge branch 'master' into JDK-8332084-restoreEcho-readLock
> - get/setEcho()
> - Addresses a review comment
> - Replaced another unused exception with _
> - Update src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java
>
> Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
> - ... and 1 more: https://git.openjdk.org/jdk/compare/b2ea52b6...69ec27d6
Latest updates look good.
-------------
Marked as reviewed by smarks (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19184#pullrequestreview-2077341454
More information about the core-libs-dev
mailing list