RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist [v2]

SendaoYan syan at openjdk.org
Sun May 26 07:24:16 UTC 2024


> Hi all,
>   When there is no `/usr/bin/expect` in system, `throw new SkippedException` will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause this testcase run failed. So I make change from `throw new SkippedException` to `System.exit` to avoid this issue. When use `System.exit`, I think we should use `othervm` mode in jtreg.
>   Only change the testcase, the risk is low.
> 
> Thanks.

SendaoYan has updated the pull request incrementally with two additional commits since the last revision:

 - delete "static final int JCK_STATUS_BASE = 95;"
   
   Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>
 - 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
   
   Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19403/files
  - new: https://git.openjdk.org/jdk/pull/19403/files/90fa1e13..57b4dee5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19403&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19403&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/19403.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19403/head:pull/19403

PR: https://git.openjdk.org/jdk/pull/19403


More information about the core-libs-dev mailing list