RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist [v2]
Daniel JeliĆski
djelinski at openjdk.org
Sun May 26 07:43:03 UTC 2024
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException` will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause this testcase run failed. So I make change from `throw new SkippedException` to `Assumptions.abort` to avoid this issue.
>> Only change the testcase, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>
> - delete "static final int JCK_STATUS_BASE = 95;"
>
> Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>
> - 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
>
> Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>
LGTM. I assume you verified it does the right thing.
-------------
Marked as reviewed by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19403#pullrequestreview-2079496098
More information about the core-libs-dev
mailing list