RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]
Phil Race
prr at openjdk.org
Fri Nov 1 18:46:57 UTC 2024
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port. This port was [deprecated for removal in JDK 21](https://openjdk.org/jeps/449) with the express intent to remove it in a future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove superfluous check for 64-bit on Windows in MacroAssembler::call_clobbered_xmm_registers
> - Remove windows-32-bit code in CompilerConfig::ergo_initialize
make/modules/jdk.accessibility/Lib.gmk line 57:
> 55: TARGETS += $(BUILD_LIBJAVAACCESSBRIDGE)
> 56:
> 57: ##############################################################################
Most of the desktop related changes are related to Assistive Technologies
I don't think we currently provide a 32-bit windowsaccessbridge.dll in the 64 bit JDK, but I'd like to be sure I am not forgetting something.
The point being windowsaccessbridge.dll is not loaded by the JDK, but by an AT, so traditionally we provided both 32 and 64 bit versions because we don't control that AT.
So I would like Alex Zuev to review these changes. For whatever reason his git hub handle doesn't seem to be found. I think it is something like @azuev-java
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1826177047
More information about the core-libs-dev
mailing list