RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]
Alexander Zuev
kizune at openjdk.org
Sat Nov 2 07:53:44 UTC 2024
On Fri, 1 Nov 2024 18:44:02 GMT, Phil Race <prr at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Remove superfluous check for 64-bit on Windows in MacroAssembler::call_clobbered_xmm_registers
>> - Remove windows-32-bit code in CompilerConfig::ergo_initialize
>
> make/modules/jdk.accessibility/Lib.gmk line 57:
>
>> 55: TARGETS += $(BUILD_LIBJAVAACCESSBRIDGE)
>> 56:
>> 57: ##############################################################################
>
> Most of the desktop related changes are related to Assistive Technologies
> I don't think we currently provide a 32-bit windowsaccessbridge.dll in the 64 bit JDK, but I'd like to be sure I am not forgetting something.
> The point being windowsaccessbridge.dll is not loaded by the JDK, but by an AT, so traditionally we provided both 32 and 64 bit versions because we don't control that AT.
>
> So I would like Alex Zuev to review these changes. For whatever reason his git hub handle doesn't seem to be found. I think it is something like @azuev-java
We built 32-bit dll in order to provide access to the accessibility interfaces for the legacy 32-bit software that can not load the 32-bit code. We abandoned this practice since at least Java 11 and we had no complaints about it ever since. All the relevant accessibility software we are aware of have 64-bit executable and only support 32-bit operating systems with the legacy versions that are not recommended to use with modern OSes. I do not see any problem in abandoning 32-bit code in windowsaccessbridge.dll.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1826520980
More information about the core-libs-dev
mailing list