RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]
Kim Barrett
kbarrett at openjdk.org
Mon Nov 4 09:03:42 UTC 2024
On Mon, 4 Nov 2024 02:34:13 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Remove superfluous check for 64-bit on Windows in MacroAssembler::call_clobbered_xmm_registers
>> - Remove windows-32-bit code in CompilerConfig::ergo_initialize
>
> src/hotspot/share/adlc/adlc.hpp line 43:
>
>> 41:
>> 42: /* Make sure that we have the intptr_t and uintptr_t definitions */
>> 43: #ifdef _WIN32
>
> As this is a synonym for `_WINDOWS` it is not obvious this deletion is correct.
The deletion is apparently working, else we'd be getting build failures. So
while there are some potential issues and opportunities for further cleanup in
this file, I think they ought to be addressed separately from this PR. See
new https://bugs.openjdk.org/browse/JDK-8343530.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1827395928
More information about the core-libs-dev
mailing list