RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]

David Holmes dholmes at openjdk.org
Mon Nov 4 09:13:43 UTC 2024


On Mon, 4 Nov 2024 09:00:59 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/share/adlc/adlc.hpp line 43:
>> 
>>> 41: 
>>> 42: /* Make sure that we have the intptr_t and uintptr_t definitions */
>>> 43: #ifdef _WIN32
>> 
>> As this is a synonym for `_WINDOWS` it is not obvious this deletion is correct.
>
> The deletion is apparently working, else we'd be getting build failures. So
> while there are some potential issues and opportunities for further cleanup in
> this file, I think they ought to be addressed separately from this PR. See
> new https://bugs.openjdk.org/browse/JDK-8343530.

There is a difference between "working" and not causing a build failure. I suspect none of that code is actually needed these days, but I'm not sure. As deleting the entire section goes beyond deleting 32-bit code, I would expect it to be partially restored in this PR and then cleaned up in a later PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1827408129


More information about the core-libs-dev mailing list