RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v41]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 4 17:12:48 UTC 2024
On Wed, 30 Oct 2024 22:41:49 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with 20 additional commits since the last revision:
>>
>> - Some test fixes
>> - Remove period in jlink.properties
>> - Revert changes to ResourcePoolEntry
>> - Fix comment in RuntimeImageLinkException
>> - Remove ImageReader (like JmodsReader)
>> - More comment fixes (JlinkTask)
>> - Move some comments around
>> - More comment fix-ups (JRTArchive)
>> - Fix description of configure option
>> - Some more wording updates
>> - ... and 10 more: https://git.openjdk.org/jdk/compare/83a86d06...e6b3aeb1
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java line 195:
>
>> 193: plugins.storeFiles(allContent.resourcePool(), result, writer);
>> 194: } catch (RuntimeImageLinkException e) {
>> 195: throwRuntimeLinkFailure(e);
>
> Curious why this is a special case. Would it be useful for debugging if this throws `new IOException(e)` the same way as other exceptions (line 196-200) so RILE is a cause?
This is in fact not needed. I've removed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1828083387
More information about the core-libs-dev
mailing list