RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v41]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 4 17:21:54 UTC 2024


On Wed, 30 Oct 2024 22:44:45 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with 20 additional commits since the last revision:
>> 
>>  - Some test fixes
>>  - Remove period in jlink.properties
>>  - Revert changes to ResourcePoolEntry
>>  - Fix comment in RuntimeImageLinkException
>>  - Remove ImageReader (like JmodsReader)
>>  - More comment fixes (JlinkTask)
>>  - Move some comments around
>>  - More comment fix-ups (JRTArchive)
>>  - Fix description of configure option
>>  - Some more wording updates
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/83a86d06...e6b3aeb1
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java line 255:
> 
>> 253:         } catch (RuntimeImageLinkException re) {
>> 254:             // Might be thrown when linking from the current run-time image.
>> 255:             // Populate the actual reason.
> 
> `// Populate the actual reason.`  - this comment no longer applies?

Indeed. This isn't needed as it's handled closer to when the exception actually happens. I've removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1828095360


More information about the core-libs-dev mailing list