RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v42]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 4 18:32:54 UTC 2024


On Thu, 31 Oct 2024 18:20:36 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 172 commits:
>> 
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Some test fixes
>>  - Remove period in jlink.properties
>>  - Revert changes to ResourcePoolEntry
>>  - Fix comment in RuntimeImageLinkException
>>  - Remove ImageReader (like JmodsReader)
>>  - More comment fixes (JlinkTask)
>>  - Move some comments around
>>  - More comment fix-ups (JRTArchive)
>>  - Fix description of configure option
>>  - ... and 162 more: https://git.openjdk.org/jdk/compare/c40bb762...b702ba8c
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/LinkableRuntimeImage.java line 77:
> 
>> 75:             }
>> 76:             return null;
>> 77:         }
> 
> the callers of this method catches `IOException` and the handler is different.   It seems to me that this method should just throw IOException.   Returns null only if no diff file for that module is present.

OK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1828200301


More information about the core-libs-dev mailing list