RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v42]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 4 18:55:47 UTC 2024


On Thu, 31 Oct 2024 18:37:50 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 172 commits:
>> 
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Some test fixes
>>  - Remove period in jlink.properties
>>  - Revert changes to ResourcePoolEntry
>>  - Fix comment in RuntimeImageLinkException
>>  - Remove ImageReader (like JmodsReader)
>>  - More comment fixes (JlinkTask)
>>  - Move some comments around
>>  - More comment fix-ups (JRTArchive)
>>  - Fix description of configure option
>>  - ... and 162 more: https://git.openjdk.org/jdk/compare/c40bb762...b702ba8c
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line 123:
> 
>> 121: \ and cannot be used to create another image with the jdk.jlink module
>> 122: err.runtime.link.packaged.mods=--keep-packaged-modules is not allowed. This run-time image capable JDK\
>> 123: \ does not include packaged modules
> 
> I think this error indicates that this JDK does not have any packaged modules, i.e. no default module path `jmods` directory.
> 
> It may be clearer to say:
> 
> Suggestion:
> 
> err.runtime.link.packaged.mods=This JDK has no packaged modules.  --keep-packaged-modules is not supported.

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1828214396


More information about the core-libs-dev mailing list