RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v42]

Severin Gehwolf sgehwolf at openjdk.org
Tue Nov 5 17:05:49 UTC 2024


On Thu, 31 Oct 2024 23:20:30 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> `test/jdk/tools/jlink/JmodLess` can be renamed to `linkableRuntimeImage` or a name consistent with the JEP.

Renamed to `runtimeImage`. As it's in the `jlink` folder already it's implied that it's the link from run-time image then.

> test/jtreg-ext/requires/VMProps.java line 743:
> 
>> 741:         // jdk.jlink module has the following resource indicating a runtime-linkable
>> 742:         // image. It's the diff file for runtime linking of the java.base module.
>> 743:         String linkableRuntimeResource = "jdk/tools/jlink/internal/runtimelink/diff_java.base";
> 
> Can this access `LinkableRuntimeImage::DIFF_PATTERN` via qualified exports?

I don't see how, but I may be missing something. `VMProps` isn't in any named module is it? Is it worth sprinkling `jdk.jlink`'s `module-info.java` classes with those exports for test-only purposes, though? Is there precedent that I can look at?

It appears this hard-coded resource seems the lesser of the two evils to me. Thoughts?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2457721189
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1829713235


More information about the core-libs-dev mailing list