[jpackage] Changes to icon handling between Java 17 and Java 21 on Windows

[Daniel Peintner]

Hi Alexey, all,

Thank you very much for your reply and the pointers you provided.

Honestly I don't mind whether the ico file is part of the exe or not. It
should just work as expected.
Having said that, we are seeing issues that in some cases it doesn't seem
to work (i.e., not showing any icon).

Let's hope this is an exception🤞

Thanks,

-- Daniel



On Wed, Nov 6, 2024 at 7:04 PM Alexey Semenyuk <alexey.semenyuk at oracle.com>
wrote:

> Hi Daniel,
>
> On Windows, the jpackage embeds icons in app launcher executables and
> there is no reason to keep these .ico files in the app image. In [1], it
> was reasonably requested not to include app launcher icons in the app
> image on Windows, and that was fulfilled.
>
> [1] https://bugs.openjdk.org/browse/JDK-8281682
>
> - Alexey
>
>
> On 11/6/2024 4:19 AM, Daniel Peintner wrote:
> > Hello,
> >
> > I am not sure if this is the right place to ask, but I hope so.
> > If not please let me know where I can report this kind of problem.
> >
> > Recently we changed from JDK 17 to JDK 21 and something seems to have
> > changed when running jpackage with --icon option.
> >
> > Produced structure on Windows for
> >
> > # Java 17
> > /app
> > /runtime
> > foo.exe
> > foo.ico
> >
> > while for
> >
> > # Java 21 (v 21.0.5)
> > /app
> > /runtime
> > foo.exe
> >
> > As you can see the foo.ico is missing.
> > Note: the foo.exe still shows the right icon when looking at it in
> > FileExplorer.
> >
> > Anyhow, on some devices the missing ico file is causing issues.
> > There is no icon on the program list nor in the taskbar (see attached
> > images).
> >
> > Note: On some windows installations it works without issues.
> >
> > Is this a known problem? I tried to browse through
> > https://bugs.openjdk.org without finding such a bug report.
> >
> > Thanks for any input/advice.
> >
> > -- Daniel
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20241107/d669f791/attachment.htm>