RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v31]
Kim Barrett
kbarrett at openjdk.org
Thu Nov 7 18:42:02 UTC 2024
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A future me chasing a bug would be surprised if we broke 64-bit Windows with this "cleanup" PR. I think the PR like this should only carry the changes that are provably, uncontroversially, visibly safe. Everything else that has any chance to do semantic changes, should be done in follow-up PRs, IMO.
> @shipilev Sure, I can revert the `_stdcall` changes from here and put them in a a separate PR. Kim also expressed a similar wish.
To be clear, I wished it had been done as a separate followup, but reviewed it here all the same, in the interest of
limiting review and testing churn. If you back it out, that will be more churn that I don't think is particularly
beneficial. I'll go along with whatever @magicus and @shipilev and @tstuefe decide to do about it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2462963330
More information about the core-libs-dev
mailing list