RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v31]

Magnus Ihse Bursie ihse at openjdk.org
Fri Nov 8 09:35:26 UTC 2024


On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A future me chasing a bug would be surprised if we broke 64-bit Windows with this "cleanup" PR. I think the PR like this should only carry the changes that are provably, uncontroversially, visibly safe. Everything else that has any chance to do semantic changes, should be done in follow-up PRs, IMO.

@shipilev Could you consider accepting the existing `__stdcall` changes in this PR? That seems like the easiest way out of satisfying everyones opinions here..

As I said, I think they are just as safe as any other changes -- the only difference is that it is perhaps not as well-known in the community that they only affect x86.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2464232813


More information about the core-libs-dev mailing list