RFR: 8342650: Move getChars to DecimalDigits [v4]
Chen Liang
liach at openjdk.org
Mon Nov 11 12:33:30 UTC 2024
On Sun, 10 Nov 2024 08:58:18 GMT, Shaojin Wen <swen at openjdk.org> wrote:
>> Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to reduce duplication
>>
>> 1. HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF16
>> 2. Putting these two methods into DecimalDigits can avoid the need to expose them in JavaLangAccess
>> 3. Eliminate duplicate code in BigDecimal
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> add benchmark
I think the fix is easy: Unsafe calls are using a bad offset which should be cast to long. Will submit a PR, but since I cannot reproduce the original issue locally or on internal CI, need others review first.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21593#issuecomment-2468066742
More information about the core-libs-dev
mailing list