RFR: 8342650: Move getChars to DecimalDigits [v4]
Shaojin Wen
swen at openjdk.org
Mon Nov 11 12:45:15 UTC 2024
On Sun, 10 Nov 2024 08:58:18 GMT, Shaojin Wen <swen at openjdk.org> wrote:
>> Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to reduce duplication
>>
>> 1. HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF16
>> 2. Putting these two methods into DecimalDigits can avoid the need to expose them in JavaLangAccess
>> 3. Eliminate duplicate code in BigDecimal
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> add benchmark
I submitted a rollback PR #22012. I can't reproduce the problem on a MacBook M1 Max, but I agree that more testing is needed, so let's roll it back first.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21593#issuecomment-2468089941
More information about the core-libs-dev
mailing list