RFR: 8341260: Add Float16 to jdk.incubator.vector [v11]

Jatin Bhateja jbhateja at openjdk.org
Wed Nov 13 05:50:49 UTC 2024


On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Port of Float16 from java.lang in the lworld+fp16 branch to jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Respond to review feedback.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 91:

> 89: // JEP-401 (https://openjdk.org/jeps/401).
> 90: // @jdk.internal.MigratedValueClass
> 91: // @jdk.internal.ValueBased

Please uncomment value-based class annotation.
Float16 does comply with the semantics of value-based classes.
https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/doc-files/ValueBased.html

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1835875585


More information about the core-libs-dev mailing list