RFR: 8341260: Add Float16 to jdk.incubator.vector [v11]

Joe Darcy darcy at openjdk.org
Wed Nov 13 06:43:21 UTC 2024


On Mon, 11 Nov 2024 02:09:41 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 91:
> 
>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>> 90: // @jdk.internal.MigratedValueClass
>> 91: // @jdk.internal.ValueBased
> 
> Please uncomment value-based class annotation.
> Float16 does comply with the semantics of value-based classes.
> https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/doc-files/ValueBased.html

The jdk.internal.ValueBased annotation is not exported for use outside of the java.base module.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1839565417


More information about the core-libs-dev mailing list