RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v7]

Alan Bateman alanb at openjdk.org
Thu Nov 14 12:02:15 UTC 2024


On Wed, 13 Nov 2024 21:39:54 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8343039: Remove failing getDeclaredField call from test java/lang/ProcessBuilder/Basic.java

I've changed the PR to require at least two reviewers as I think the changes could benefit from a second reviewer.

src/java.base/share/classes/java/io/BufferedOutputStream.java line 89:

> 87: 
> 88:         if (getClass() == BufferedOutputStream.class) {
> 89:             // resizable if initialSize < maxSize

I think the comment is confusing, can it just say resizable when not sub-classed as it did previously?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22048#issuecomment-2476163286
PR Review Comment: https://git.openjdk.org/jdk/pull/22048#discussion_r1842102399


More information about the core-libs-dev mailing list