RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v7]

ExE Boss duke at openjdk.org
Thu Nov 14 13:21:56 UTC 2024


On Thu, 14 Nov 2024 11:59:47 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8343039: Remove failing getDeclaredField call from test java/lang/ProcessBuilder/Basic.java
>
> src/java.base/share/classes/java/io/BufferedOutputStream.java line 89:
> 
>> 87: 
>> 88:         if (getClass() == BufferedOutputStream.class) {
>> 89:             // resizable if initialSize < maxSize
> 
> I think the comment is confusing, can it just say resizable when not sub-classed as it did previously?

Suggestion:

            // resizable when not sub-classed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22048#discussion_r1842207003


More information about the core-libs-dev mailing list