RFR: 8344183: (zipfs) SecurityManager cleanup in the ZipFS area

[Eirik Bjørsnøs]

On Thu, 14 Nov 2024 14:01:45 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Please review this PR which cleans up SecurityManager-related code following JEP-486 integraion.
>> 
>> * `ZipFileSystem` is updated to not perform `AccessController::doPrivileged`
>> * `ZipFileSystemProvider` is updated to not perform `AccessController::doPrivileged`
>> *  The test `TestPosix` is updated to perform `AccessController.doPrivileged`
>> 
>> This change should be relatively straight-forward to review. Reviewers may want to look extra close at the exception-unwrapping code in `ZipFileSystem::initOwner` and `ZipFileSystem::initGroup`.
>> 
>> Testing: Tests in `test/jdk/jdk/nio/zipfs` run green locally.
>
> test/jdk/jdk/nio/zipfs/TestPosix.java line 224:
> 
>> 222:         } catch (IOException e) {
>> 223:             System.out.println("Caught " + e.getClass().getName() + "(" + e.getMessage() +
>> 224:                     ") when running a privileged operation to get the default owner.");
> 
> Given we are not running a privileged operation, we should probably tweak the exception message

Thanks, I was a bit of a robot here and didn't read the exception message :-)

I think it might be better to simply propagate this IOException to the calling method `testPosixDefaults`. This method throws IOException. Catching this IOException here provides limited value.

What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22101#discussion_r1842289557