RFR: 8344183: (zipfs) SecurityManager cleanup in the ZipFS area

[Lance Andersen]

On Thu, 14 Nov 2024 14:11:57 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> test/jdk/jdk/nio/zipfs/TestPosix.java line 224:
>> 
>>> 222:         } catch (IOException e) {
>>> 223:             System.out.println("Caught " + e.getClass().getName() + "(" + e.getMessage() +
>>> 224:                     ") when running a privileged operation to get the default owner.");
>> 
>> Given we are not running a privileged operation, we should probably tweak the exception message
>
> Thanks, I was a bit of a robot here and didn't read the exception message :-)
> 
> I think it might be better to simply propagate this IOException to the calling method `testPosixDefaults`. This method throws IOException. Catching this IOException here provides limited value.
> 
> What do you think?

For this specific PR, I might just change the error message and revisit once we deal with the SM to avoid any unexpected surprises (one bitten twice shy ;-) )

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22101#discussion_r1842323725