RFR: 8344183: (zipfs) SecurityManager cleanup in the ZipFS area [v2]

Eirik Bjørsnøs eirbjo at openjdk.org
Thu Nov 14 14:43:50 UTC 2024


On Thu, 14 Nov 2024 14:31:03 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Thanks, I was a bit of a robot here and didn't read the exception message :-)
>> 
>> I think it might be better to simply propagate this IOException to the calling method `testPosixDefaults`. This method throws IOException. Catching this IOException here provides limited value.
>> 
>> What do you think?
>
> For this specific PR, I might just change the error message and revisit once we deal with the SM to avoid any unexpected surprises (one bitten twice shy ;-) )

Okay, I've tweaked the debug messages to not reference privileged actions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22101#discussion_r1842339786


More information about the core-libs-dev mailing list