RFR: 8344289: SM cleanup in jdk.internal.util [v2]

Eirik Bjørsnøs eirbjo at openjdk.org
Fri Nov 15 15:43:08 UTC 2024


> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and `StaticProperty` in the `jdk.internal.util` namespace:
> 
> * `RandomSupport` is updated to replace an `AccessController::doPrivileged` call with `Boolean::getBoolean`. (Existing code uses `String::equalsIgnoreCase`, equivalent to `Boolean::getBoolean`)
> * `ClassFileDumper` constructor is updated to remove a comment referencing `GetPropertyAction`. (I left the `VM::getSavedProperty` call as-is, please advise if this should be replaced with `System::getProperty)
> * `ClassFileDumper::write` is updated to unwrap a `AccessController::doPrivileged` call
> * `StaticProperty` is updated to remove `SecurityManager::checkPropertyAccess` references in the documentation
> 
> Verification: GHA results pending.

Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:

  Remove redundant suppression

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22141/files
  - new: https://git.openjdk.org/jdk/pull/22141/files/09c7c2e3..64a9ec15

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22141&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22141&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22141.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22141/head:pull/22141

PR: https://git.openjdk.org/jdk/pull/22141


More information about the core-libs-dev mailing list