RFR: 8344289: SM cleanup in jdk.internal.util [v2]

[Roger Riggs]

On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and `StaticProperty` in the `jdk.internal.util` namespace:
>> 
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged` call with `Boolean::getBoolean`. (Existing code uses `String::equalsIgnoreCase`, equivalent to `Boolean::getBoolean`)
>> * `ClassFileDumper` constructor is updated to remove a comment referencing `GetPropertyAction`. (I left the `VM::getSavedProperty` call as-is, please advise if this should be replaced with `System::getProperty)
>> * `ClassFileDumper::write` is updated to unwrap a `AccessController::doPrivileged` call
>> * `StaticProperty` is updated to remove `SecurityManager::checkPropertyAccess` references in the documentation
>> 
>> Verification: GHA results pending.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant suppression

LGTM

src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:

> 80: 
> 81:     private ClassFileDumper(String key, String path) {
> 82:         /*

The comment might still be relevant if changed to System.getProperty.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22141#pullrequestreview-2439033301
PR Review Comment: https://git.openjdk.org/jdk/pull/22141#discussion_r1844099955