RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v3]
Alexey Semenyuk
asemenyuk at openjdk.org
Tue Nov 19 22:07:10 UTC 2024
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken and can NOT be repaired due to WiX's limitations.
>
> Repaired scenario when the `--dest` option references a long path on Windows. Previously jpackage would have failed to build MSI package.
>
> Other changes:
> - Rename `Executor.setRemovePath()` into `Executor.setRemovePathEnvVar()` to make the method name match the implementation.
> - Move the mutable part of `WixPipeline` class into `WixPipeline.Builder` class.
> - Fixed minor flaws in "WinL10nTest.java"
Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
Make path guaranteed to be long enough
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22092/files
- new: https://git.openjdk.org/jdk/pull/22092/files/92cf525d..d73e1279
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22092&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22092&range=01-02
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/22092.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22092/head:pull/22092
PR: https://git.openjdk.org/jdk/pull/22092
More information about the core-libs-dev
mailing list