RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v2]
Taizo Kurashige
duke at openjdk.org
Wed Nov 20 01:44:05 UTC 2024
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" executed with "chcp 65001". This ensures that the encoding is UTF8 and that the English message "No Instance(s) Available." is output on localized windows platforms.
>
> I have referred to the following for how to use chcp:
> ・chcp | Microsoft Learn at https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp
> ・Code Page Identifiers - Win32 apps | Microsoft Learn at https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers
>
> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019 (Japanese and English locales). I confirmed that they pass.
>
> Thanks
Taizo Kurashige has updated the pull request incrementally with five additional commits since the last revision:
- Merge branch 'fix_Win8301247Test_bug' of https://github.com/kurashige23/jdk into fix_Win8301247Test_bug
- Chenge code page from 65001 to 437
- Fix how to execute chcp command
- Change setWinEnableUTF8 to setWinRunWithEnglishOutput
- Suppress the output of chcp command
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22142/files
- new: https://git.openjdk.org/jdk/pull/22142/files/b1ee8f6f..09853425
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22142&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22142&range=00-01
Stats: 37 lines in 2 files changed: 11 ins; 7 del; 19 mod
Patch: https://git.openjdk.org/jdk/pull/22142.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22142/head:pull/22142
PR: https://git.openjdk.org/jdk/pull/22142
More information about the core-libs-dev
mailing list