RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v3]

Taizo Kurashige duke at openjdk.org
Wed Nov 20 01:47:34 UTC 2024


> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" executed with "chcp 65001". This ensures that the encoding is UTF8 and that the English message "No Instance(s) Available." is output on localized windows platforms.
> 
> I have referred to the following for how to use chcp:
> ・chcp | Microsoft Learn at https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp
> ・Code Page Identifiers - Win32 apps | Microsoft Learn at https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers
> 
> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019 (Japanese and English locales). I confirmed that they pass.
> 
> Thanks

Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision:

  Fix indent

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22142/files
  - new: https://git.openjdk.org/jdk/pull/22142/files/09853425..0d9fee82

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22142&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22142&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22142.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22142/head:pull/22142

PR: https://git.openjdk.org/jdk/pull/22142


More information about the core-libs-dev mailing list