RFR: 8343839: Detect patched modules and abort run-time image link early [v2]

Severin Gehwolf sgehwolf at openjdk.org
Wed Nov 20 17:03:00 UTC 2024


> Please review this fix to how patched modules are being handled when linking from the run-time image. During review of [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out that module patching should be detected earlier and the link should get aborted in that case.
> 
> This patch implements it, by looking at the `jdk.module.patch.0` property like [other code in the JDK](https://github.com/openjdk/jdk/blob/2c1e4c381615ce52276f4bf331a1e7a845af4b6e/src/hotspot/share/cds/cdsConfig.cpp#L282) does. After this patch module patching is being detected before any archives are being read or the actual linking process starts (contrary to the previous solution).
> 
> Testing:
> - [x] GHA testing (mac aarch64 test failures are infra related)
> - [x] Local testing of existing test, which covers it
> 
> Thoughts?

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Revert module export to jdk.jlink
 - Review feedback and depend on JDK-8344560
 - Merge branch 'jdk-8344560-jdk.patched-property' into jdk-8343839-detect-patch-module
 - 8343839: Detect patched modules and abort run-time image link early

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22037/files
  - new: https://git.openjdk.org/jdk/pull/22037/files/2d6d1f40..81917340

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22037&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22037&range=00-01

  Stats: 164100 lines in 3375 files changed: 50017 ins; 102678 del; 11405 mod
  Patch: https://git.openjdk.org/jdk/pull/22037.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22037/head:pull/22037

PR: https://git.openjdk.org/jdk/pull/22037


More information about the core-libs-dev mailing list