RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v17]

[fabioromano1]

On Tue, 1 Oct 2024 15:34:12 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code simplification
>
> test/jdk/java/math/BigInteger/MutableBigIntegerShiftTests.java line 69:
> 
>> 67:     @MethodSource("pathTargetedCases")
>> 68:     public void test(MutableBigIntegerBox x, int n) {
>> 69:         leftShiftAssertions(x, n);
> 
> One last thing... It would make sense to inline `leftShiftAssertions()` and remove it?

I preferred to put the assertions in a different method, in case that tests for `MBI.rightShift()` would be added in future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1783136391