RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v17]

Raffaello Giulietti rgiulietti at openjdk.org
Tue Oct 1 16:27:39 UTC 2024


On Tue, 1 Oct 2024 14:21:19 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> This implementation of MutableBigInteger.leftShift(int) optimizes the current version, avoiding unnecessary copy of the MutableBigInteger's value content and performing the primitive shifting only in the original portion of the value array rather than in the value yet extended with trailing zeros.
>
> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Code simplification

Looks good.
Thanks.

-------------

Marked as reviewed by rgiulietti (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20008#pullrequestreview-2340865137


More information about the core-libs-dev mailing list