RFR: 8336843: Deprecate java.util.zip.ZipError for removal [v3]
Alan Bateman
alanb at openjdk.org
Tue Oct 1 16:15:42 UTC 2024
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
>> Please review this PR which suggests to deprecate the unused class `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from native to Java in JDK 9.
>>
>> I opted to not explain the reason for the deprecation in detail, but instead simply point to `ZipException` as an alternative. Should more explanation be desired, I could prepend that with a note saying that the class is unused since JDK 9.
>>
>> A CSR for this API update has been drafted, I'll update the Specification section there once we reach a concensus on the deprecation note in this PR.
>>
>> This deprecation was initially suggested here: https://mail.openjdk.org/pipermail/core-libs-dev/2024-June/125720.html
>
> Eirik Bjørsnøs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into ziperror-deprecation
> - Simplify the deprecation note by focusing on behavior in the current release
> - Extend the deprecation note to mention that the error became obsolete in JDK 9 and to mention that code may be updated to catch the super class InternalError
> - Update copyright year
> - Deprecate java.util.zip.ZipError for removal
src/java.base/share/classes/java/util/zip/ZipError.java line 31:
> 29: * Signals that an unrecoverable error has occurred.
> 30: *
> 31: * @deprecated ZipError is no longer used and is obsolete.
I agree ZipError should be deprecated. Can the JBS issue and PR title be updated as they still have "for removal".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20642#discussion_r1783148525
More information about the core-libs-dev
mailing list