RFR: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils [v2]
Chen Liang
liach at openjdk.org
Sun Oct 6 16:30:36 UTC 2024
On Sun, 6 Oct 2024 15:27:07 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> copyright
>
> test/micro/org/openjdk/bench/java/util/zip/ZipFileOpen.java line 110:
>
>> 108: zf2.close();
>> 109: }
>> 110:
>
> A short comment stating the purpose of the main method would not hurt.
https://github.com/openjdk/jdk/pull/19477#discussion_r1725802115
This applies to many benchmarks, so I wonder where is the best place for such a note.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21377#discussion_r1789156614
More information about the core-libs-dev
mailing list