RFR: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils [v3]

Claes Redestad redestad at openjdk.org
Sun Oct 6 19:24:49 UTC 2024


On Sun, 6 Oct 2024 16:27:52 GMT, Chen Liang <liach at openjdk.org> wrote:

>> test/micro/org/openjdk/bench/java/util/zip/ZipFileOpen.java line 110:
>> 
>>> 108:         zf2.close();
>>> 109:     }
>>> 110: 
>> 
>> A short comment stating the purpose of the main method would not hurt.
>
> https://github.com/openjdk/jdk/pull/19477#discussion_r1725802115
> 
> This applies to many benchmarks, so I wonder where is the best place for such a note.

I think it's fair to add a descriptive comment individually.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21377#discussion_r1789216833


More information about the core-libs-dev mailing list