RFR: 8338544: Dedicated Array class descriptor implementation [v3]
Chen Liang
liach at openjdk.org
Tue Oct 8 20:48:58 UTC 2024
On Tue, 8 Oct 2024 19:47:06 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> mlchung suggestions: elementType, improve utility methods
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 281:
>
>> 279: *
>> 280: * @implSpec
>> 281: * <p>The implementations return the simple name
>
> Suggestion:
>
> * <p>The implementation returns the simple name
>
>
> I think this can be singular as it's not required to have more than 1 implementation class.
Hmm, in fact, should we still have this `@implSpec` if we make this default?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20665#discussion_r1792488546
More information about the core-libs-dev
mailing list