RFR: 8338544: Dedicated Array class descriptor implementation [v3]

Mandy Chung mchung at openjdk.org
Tue Oct 8 21:09:58 UTC 2024


On Tue, 8 Oct 2024 20:46:13 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 281:
>> 
>>> 279:      *
>>> 280:      * @implSpec
>>> 281:      * <p>The implementations return the simple name
>> 
>> Suggestion:
>> 
>>      * <p>The implementation returns the simple name
>> 
>> 
>> I think this can be singular as it's not required to have more than 1 implementation class.
>
> Hmm, in fact, should we still have this `@implSpec` if we make this default?

I think this can be dropped as `ClassDesc` as well.   It can say "This method returns....".   See what CSR review would say.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20665#discussion_r1792509783


More information about the core-libs-dev mailing list