RFR: 8341566: Add Reader.of(CharSequence) [v7]

Markus KARG duke at openjdk.org
Wed Oct 9 20:11:18 UTC 2024


On Wed, 9 Oct 2024 18:59:58 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - assertThrows instead of expectedExceptions
>>  - ordered jtreg tags according recommendation in https://openjdk.org/jtreg/tag-spec.html#ORDER
>
> test/jdk/java/io/Reader/Of.java line 40:
> 
>> 38:  * @bug 8341566
>> 39:  * @summary Check for expected behavior of Reader.of().
>> 40:  * @run testng Of
> 
> The test name should be more descriptive.  Without the package name it is unknown what this test does or what it tests.

The test name follows the conventions currently applied in this folder. Feel free to propose a better name, I would be happy to change it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1794163340


More information about the core-libs-dev mailing list