RFR: 8341566: Add Reader.of(CharSequence) [v7]

Roger Riggs rriggs at openjdk.org
Wed Oct 9 21:15:16 UTC 2024


On Wed, 9 Oct 2024 20:08:25 GMT, Markus KARG <duke at openjdk.org> wrote:

>> test/jdk/java/io/Reader/Of.java line 40:
>> 
>>> 38:  * @bug 8341566
>>> 39:  * @summary Check for expected behavior of Reader.of().
>>> 40:  * @run testng Of
>> 
>> The test name should be more descriptive.  Without the package name it is unknown what this test does or what it tests.
>
> The test name follows the conventions currently applied in this folder. Feel free to propose a better name, I would be happy to change it.

The test name should provide enough context so the *human* reader does not have to hunt around for the context.
Either CharSequenceReader or ReaderOfCharSequence would be easier to understand without having to *know* the conventions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1794235847


More information about the core-libs-dev mailing list