RFR: 8317356: Test ClassFile API if it deals with nulls correctly across the whole API

Adam Sotona asotona at openjdk.org
Fri Oct 11 16:07:13 UTC 2024


On Fri, 11 Oct 2024 16:02:29 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/classfile/impl/ClassRemapperImpl.java line 276:
>> 
>>> 274:     @Override
>>> 275:     public ClassDesc map(ClassDesc desc) {
>>> 276:         if (desc == null) return null;
>> 
>> I'm not sure this won't break some use case.
>> Here I would say null -> null mapping might be OK.
>
> Makes sense. I will push the changes when you finish the review.

It is all I have.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21458#discussion_r1797160380


More information about the core-libs-dev mailing list