RFR: 8317356: Test ClassFile API if it deals with nulls correctly across the whole API [v2]
Chen Liang
liach at openjdk.org
Fri Oct 11 16:21:30 UTC 2024
> Please review this patch that adds a test by @nizarbenalla to perform null checks across the ClassFile API. This is an updated version of #20556 that minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `MethodHandleProxies` to explicitly use platform class loader instead of `null` for boot class loader. Tests work fine.
> 2. The null check test uses the same set of classes as CorpusTest to make it suitable for tier 1.
> 3. The test is not comprehensive; currently it is permissive toward IAE, because sometimes some substitution arguments are invalid, especially primitive ClassDesc or Opcode with wrong types.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
asotona review remarks
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21458/files
- new: https://git.openjdk.org/jdk/pull/21458/files/79443792..b4f0ebcc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21458&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21458&range=00-01
Stats: 940 lines in 3 files changed: 1 ins; 939 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/21458.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21458/head:pull/21458
PR: https://git.openjdk.org/jdk/pull/21458
More information about the core-libs-dev
mailing list