RFR: 8317356: Test ClassFile API if it deals with nulls correctly across the whole API
Chen Liang
liach at openjdk.org
Fri Oct 11 16:21:30 UTC 2024
On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang <liach at openjdk.org> wrote:
> Please review this patch that adds a test by @nizarbenalla to perform null checks across the ClassFile API. This is an updated version of #20556 that minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `MethodHandleProxies` to explicitly use platform class loader instead of `null` for boot class loader. Tests work fine.
> 2. The null check test uses the same set of classes as CorpusTest to make it suitable for tier 1.
> 3. The test is not comprehensive; currently it is permissive toward IAE, because sometimes some substitution arguments are invalid, especially primitive ClassDesc or Opcode with wrong types.
Thanks adam for the review. I have removed the test for now. We can come back later and find a more comprehensive way to test builders accessible only in transforms, etc. and the null check test might actually be incorporated with a general contract check test that checks for IAE too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21458#issuecomment-2407736668
More information about the core-libs-dev
mailing list