Integrated: 8317356: Fix missing null checks in the ClassFile API

Chen Liang liach at openjdk.org
Mon Oct 14 17:24:20 UTC 2024


On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang <liach at openjdk.org> wrote:

> Please review this patch that adds a test by @nizarbenalla to perform null checks across the ClassFile API. This is an updated version of #20556 that minimizes impact on our implementation code.
> 
> Notes:
> 1. There's one change in `MethodHandleProxies` to explicitly use platform class loader instead of `null` for boot class loader. Tests work fine.
> 2. The null check test uses the same set of classes as CorpusTest to make it suitable for tier 1.
> 3. The test is not comprehensive; currently it is permissive toward IAE, because sometimes some substitution arguments are invalid, especially primitive ClassDesc or Opcode with wrong types.

This pull request has now been integrated.

Changeset: a2c77522
Author:    Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a2c775222e17a3ba2e388c9a0eb9ffd33efad219
Stats:     262 lines in 36 files changed: 146 ins; 13 del; 103 mod

8317356: Fix missing null checks in the ClassFile API

Co-authored-by: Nizar Benalla <nbenalla at openjdk.org>
Reviewed-by: asotona

-------------

PR: https://git.openjdk.org/jdk/pull/21458


More information about the core-libs-dev mailing list